Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

processor,scheduler(ticdc): clean up unused method and metrics (#8049) #8699

Merged
merged 3 commits into from
Mar 30, 2023
Merged

processor,scheduler(ticdc): clean up unused method and metrics (#8049) #8699

merged 3 commits into from
Mar 30, 2023

Conversation

ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Mar 30, 2023 •
edited by sdojjy
Loading

This is an automated cherry-pick of #8049

What problem does this PR solve?

Issue Number: close #8048
Issue Number: close #7872

What is changed and how it works?

Clean up unused method and metrics.

This PR saves about 46.8% CPU usages of processor in the many (72k) tables scenario.

handlePosition CPU usage in master barnch.
image

checkpoint ts lag with 100k tables
image

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?

No.

Do you need to update user documentation, design documentation or monitoring documentation?

No.

Release note 

None

@overvenus @ti-chi-bot
This is an automated cherry-pick of pingcap#8049
8f263c6 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 30, 2023
Merged
@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. do-not-merge/cherry-pick-not-approved labels Mar 30, 2023
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Mar 30, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 30, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@cc29f61). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 235438b differs from pull request most recent head 6ccfc5d. Consider uploading reports for the commit 6ccfc5d to get more accurate results

Additional details and impacted files
Flag Coverage Δ
dm 52.3688% <0.0000%> (?)
engine 64.4033% <0.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             release-6.5      #8699   +/-   ##
================================================
  Coverage               ?   55.2132%           
================================================
  Files                  ?        415           
  Lines                  ?      52904           
  Branches               ?          0           
================================================
  Hits                   ?      29210           
  Misses                 ?      20923           
  Partials               ?       2771

@sdojjy
Copy link
Member

sdojjy commented Mar 30, 2023

/run-all-tests

@sdojjy sdojjy assigned sdojjy and unassigned overvenus Mar 30, 2023
@sdojjy
Copy link
Member

sdojjy commented Mar 30, 2023

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 6ccfc5d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 30, 2023
@nongfushanquan
Copy link
Contributor

/run-all-tests

@nongfushanquan
Copy link
Contributor

/run-verify

1 similar comment
@sdojjy
Copy link
Member

sdojjy commented Mar 30, 2023

/run-verify

@ti-chi-bot ti-chi-bot merged commit 885757e into pingcap:release-6.5 Mar 30, 2023
@sdojjy sdojjy mentioned this pull request Mar 31, 2023
Closed
@VelocityLight VelocityLight added do-not-merge/cherry-pick-not-approved and removed cherry-pick-approved Cherry pick PR approved by release team. labels Apr 21, 2023
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels May 22, 2023
@ti-chi-bot ti-chi-bot removed the cherry-pick-approved Cherry pick PR approved by release team. label Jun 14, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asddongmen asddongmen asddongmen approved these changes

Assignees

@sdojjy sdojjy

Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ti-chi-bot @codecov-commenter @sdojjy @nongfushanquan @asddongmen @overvenus @VelocityLight